Skip to content

Try catch notify messaging #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2025
Merged

Try catch notify messaging #1592

merged 2 commits into from
Mar 28, 2025

Conversation

jonathanKingston
Copy link
Contributor

Asana Task/Github Issue: https://app.asana.com/0/72649045549333/1209788762702038/f

Description

Due to concerns about missing handlers in WebKit, adding a try catch here just for safey sake. (we're expecting to fix this next week on the handler side).

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Due to concerns about missing handlers in WebKit, adding a try catch here just for safey sake. (we're expecting to fix this next week on the handler side).
Copy link

netlify bot commented Mar 28, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 4ba8d6c
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/67e690371111a00008bf0cd7
😎 Deploy Preview https://deploy-preview-1592--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Mar 28, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@jonathanKingston jonathanKingston marked this pull request as ready for review March 28, 2025 11:52
@jonathanKingston jonathanKingston requested a review from a team as a code owner March 28, 2025 11:52
Copy link

github-actions bot commented Mar 28, 2025

[Beta] Generated file diff

Time updated: Fri, 28 Mar 2025 12:04:47 GMT

Android
    - android/autofillPasswordImport.js
  • android/brokerProtection.js
  • android/contentScope.js

File has changed

Chrome-mv3
    - chrome-mv3/inject.js

File has changed

Firefox
    - firefox/inject.js

File has changed

Integration
    - integration/contentScope.js

File has changed

Windows
    - windows/contentScope.js

File has changed

Apple
    - dist/contentScope.js
  • dist/contentScopeIsolated.js

File has changed

@jonathanKingston jonathanKingston merged commit e78b829 into main Mar 28, 2025
14 checks passed
@jonathanKingston jonathanKingston deleted the jkt/debugFlagTryCatch branch March 28, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants