Skip to content

ntp: send background-tab on windows middle-click #1595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 3, 2025

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Mar 28, 2025

Asana Task/Github Issue: https://app.asana.com/0/0/1209828917523414/f

Description

  • on windows, send background-tab for middle-clicks

Testing Steps

  • test favorites + activity works as expected on windows

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane shakyShane marked this pull request as ready for review March 28, 2025 18:19
@shakyShane shakyShane requested review from mgurgel and a team as code owners March 28, 2025 18:19
@shakyShane
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

netlify bot commented Mar 28, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 22fa7a4
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/67eebe571eb8b4000825ee9b
😎 Deploy Preview https://deploy-preview-1595--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Mar 28, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Mar 28, 2025

[Beta] Generated file diff

Time updated: Thu, 03 Apr 2025 16:59:40 GMT

Integration
    - integration/pages/history/dist/index.js
  • integration/pages/new-tab/dist/index.js

File has changed

Windows
    - windows/pages/history/dist/index.js
  • windows/pages/new-tab/dist/index.js

File has changed

Apple
    - dist/pages/history/dist/index.js
  • dist/pages/new-tab/dist/index.js

File has changed

@mgurgel mgurgel force-pushed the shane/middle-click-windows branch from 342cfd2 to eb3b385 Compare April 2, 2025 09:45
@mgurgel mgurgel force-pushed the shane/middle-click-windows branch 3 times, most recently from 280ef87 to 22fa7a4 Compare April 3, 2025 16:59
@mgurgel mgurgel merged commit 8f55dc1 into main Apr 3, 2025
32 checks passed
@mgurgel mgurgel deleted the shane/middle-click-windows branch April 3, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants