Skip to content

ntp: support default background colors #1596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 4, 2025
Merged

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Mar 29, 2025

Asana Task/Github Issue: https://app.asana.com/0/0/1209605604219920/f

Description

  • support new, optional defaults for background colours (to support a visual refresh, which will be behind a flag)

Note

This PR is safe to merge + release before the native sides are ready.

Testing Steps (NTP)

Testing Steps (History)

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

netlify bot commented Mar 29, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 7ec2ac0
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/67efc73a07eb4e00089ba6a0
😎 Deploy Preview https://deploy-preview-1596--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Mar 29, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Mar 29, 2025

[Beta] Generated file diff

Time updated: Fri, 04 Apr 2025 11:49:55 GMT

Integration
    - integration/pages/history/dist/index.css
  • integration/pages/history/dist/index.js
  • integration/pages/new-tab/dist/index.css
  • integration/pages/new-tab/dist/index.js
  • integration/pages/new-tab/index.html

File has changed

Windows
    - windows/pages/history/dist/index.css
  • windows/pages/history/dist/index.js
  • windows/pages/new-tab/dist/index.css
  • windows/pages/new-tab/dist/index.js
  • windows/pages/new-tab/index.html

File has changed

Apple
    - dist/pages/history/dist/index.css
  • dist/pages/history/dist/index.js
  • dist/pages/new-tab/dist/index.css
  • dist/pages/new-tab/dist/index.js
  • dist/pages/new-tab/index.html

File has changed

@shakyShane shakyShane marked this pull request as ready for review March 29, 2025 11:50
@shakyShane shakyShane requested review from mgurgel and a team as code owners March 29, 2025 11:50
mgurgel
mgurgel previously approved these changes Apr 4, 2025
@mgurgel mgurgel force-pushed the shane/ntp-visual-refresh branch from e7f7987 to ae9d337 Compare April 4, 2025 11:33
@mgurgel mgurgel merged commit f996039 into main Apr 4, 2025
15 checks passed
@mgurgel mgurgel deleted the shane/ntp-visual-refresh branch April 4, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants