Skip to content

Duck Player entry point: updated messaging #1603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

mgurgel
Copy link
Contributor

@mgurgel mgurgel commented Mar 31, 2025

Asana Task/Github Issue: https://app.asana.com/0/0/1209842067000892/f

Description

In order to fire the same "dismiss-play" pixel for thumbnail clicks and clicks outside of the overlay:

  • Renamed play.do_not_use.thumbnail message to play.do_not_use.dismiss
  • Set play.do_not_use.dismiss to fire on clicks outside of the overlay too

Testing Steps

  • TBC (pending native PRs)

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@mgurgel mgurgel requested a review from a team as a code owner March 31, 2025 11:44
Copy link

netlify bot commented Mar 31, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 6898a1c
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/67f65ee2cb220b0008d17250
😎 Deploy Preview https://deploy-preview-1603--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Mar 31, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Mar 31, 2025

[Beta] Generated file diff

Time updated: Wed, 09 Apr 2025 11:50:36 GMT

Android
    - android/contentScope.js

File has changed

Integration
    - integration/contentScope.js

File has changed

Windows
    - windows/contentScope.js

File has changed

Apple
    - dist/contentScopeIsolated.js

File has changed

@mgurgel mgurgel force-pushed the mgurgel/duckplayer-new-entrypoint-update branch 2 times, most recently from fd7b5c0 to 0e9b893 Compare April 2, 2025 15:30
@mgurgel mgurgel force-pushed the mgurgel/duckplayer-new-entrypoint-update branch from 0e9b893 to 6898a1c Compare April 9, 2025 11:49
@mgurgel mgurgel self-assigned this Apr 9, 2025
Copy link
Contributor

@jonathanKingston jonathanKingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merge whenever you're ready.

@mgurgel mgurgel merged commit 3b9f41d into main Apr 9, 2025
14 checks passed
@mgurgel mgurgel deleted the mgurgel/duckplayer-new-entrypoint-update branch April 9, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants