Skip to content

Fixes privacy-config hash on CI #1605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025
Merged

Conversation

mgurgel
Copy link
Contributor

@mgurgel mgurgel commented Mar 31, 2025

Description

I upgraded privacy-configuration for the injected doc generation but didn't update package-lock.json with it, which is causing Netlify build errors on PRs. This fixes it.

Testing Steps

  • The Netlify build below should not fail

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@mgurgel mgurgel requested a review from a team as a code owner March 31, 2025 17:28
Copy link

netlify bot commented Mar 31, 2025

Deploy Preview for content-scope-scripts failed.

Name Link
🔨 Latest commit 5c4f6c0
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/67ed505a5315090008ab5f7d

Copy link

github-actions bot commented Mar 31, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Mar 31, 2025

[Beta] Generated file diff

Time updated: Wed, 02 Apr 2025 14:58:13 GMT

@mgurgel mgurgel force-pushed the mgurgel/privacy-config-hash-fix branch from 3e9959e to f33cf20 Compare April 2, 2025 14:56
@mgurgel mgurgel force-pushed the mgurgel/privacy-config-hash-fix branch from f33cf20 to 5c4f6c0 Compare April 2, 2025 14:57
@mgurgel mgurgel changed the title [WIP] Fixes privacy-config hash on CI Fixes privacy-config hash on CI Apr 2, 2025
@mgurgel mgurgel merged commit f8c5a43 into main Apr 2, 2025
10 of 14 checks passed
@mgurgel mgurgel deleted the mgurgel/privacy-config-hash-fix branch April 2, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants