Skip to content

Expand patching changes #1606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 15, 2025
Merged

Conversation

jonathanKingston
Copy link
Contributor

@jonathanKingston jonathanKingston commented Mar 31, 2025

Asana Task/Github Issue: https://app.asana.com/0/481882893211075/1209844047592403/f

Description

Adds support for more conditional matching. See tech design linked for more detailed explanation.

Testing Steps

  • Ensure that existing features aren't broken by this change; namely element-hiding.

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Copy link

netlify bot commented Mar 31, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit e38f978
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/67fe6bddd133950008024ccc
😎 Deploy Preview https://deploy-preview-1606--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Mar 31, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Mar 31, 2025

[Beta] Generated file diff

Time updated: Tue, 15 Apr 2025 14:24:08 GMT

Android
    - android/autofillPasswordImport.js
  • android/brokerProtection.js
  • android/contentScope.js

File has changed

Chrome-mv3
    - chrome-mv3/inject.js

File has changed

Firefox
    - firefox/inject.js

File has changed

Integration
    - integration/contentScope.js

File has changed

Windows
    - windows/contentScope.js

File has changed

Apple
    - dist/contentScope.js
  • dist/contentScopeIsolated.js

File has changed

@jonathanKingston jonathanKingston force-pushed the jkt/web-interventions-patching branch 7 times, most recently from 5f08041 to 5262b1f Compare March 31, 2025 20:27
@jonathanKingston jonathanKingston force-pushed the jkt/web-interventions-patching branch 2 times, most recently from d40436b to 5931c7e Compare March 31, 2025 21:06
@jonathanKingston jonathanKingston force-pushed the jkt/web-interventions-patching branch from 5931c7e to aed4fb3 Compare March 31, 2025 21:18
@jonathanKingston jonathanKingston marked this pull request as ready for review April 2, 2025 14:21
@jonathanKingston jonathanKingston requested a review from a team as a code owner April 2, 2025 14:21
@jonathanKingston jonathanKingston changed the title PoC: Add patching changes Expand patching changes Apr 3, 2025
@jonathanKingston jonathanKingston requested a review from dharb April 8, 2025 16:03
@jonathanKingston jonathanKingston force-pushed the jkt/web-interventions-patching branch from 19d8d39 to f8be42d Compare April 9, 2025 15:51
@jonathanKingston
Copy link
Contributor Author

Remote config changes here: duckduckgo/privacy-configuration#2992

This validates this new structure even if we're not going to use it immediately.

@jonathanKingston jonathanKingston merged commit e3abf7e into main Apr 15, 2025
14 checks passed
@jonathanKingston jonathanKingston deleted the jkt/web-interventions-patching branch April 15, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants