Skip to content

Ensure getFeatureSettingEnabled behaves as expected #1607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2025
Merged

Ensure getFeatureSettingEnabled behaves as expected #1607

merged 1 commit into from
Apr 2, 2025

Conversation

jonathanKingston
Copy link
Contributor

Asana Task/Github Issue: https://app.asana.com/0/0/1209854904049726/f

Description

Add tests for getFeatureSettingEnabled to ensure it remains unbroken.

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@jonathanKingston jonathanKingston requested a review from madblex April 2, 2025 09:02
@jonathanKingston jonathanKingston marked this pull request as ready for review April 2, 2025 09:02
@jonathanKingston jonathanKingston requested a review from a team as a code owner April 2, 2025 09:02
@netlify Netlify
Copy link

netlify bot commented Apr 2, 2025 •
edited
Loading

❌ Deploy Preview for content-scope-scripts failed.

Name Link
🔨 Latest commit 36afa77
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/67ecff2f8b10f10008ba218c

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2025 •
edited
Loading

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2025 •
edited
Loading

[Beta] Generated file diff

Time updated: Wed, 02 Apr 2025 09:11:49 GMT

@jonathanKingston jonathanKingston force-pushed the jkt/getFeatureSettingEnabledTests branch from ccb5ad4 to 36afa77 Compare April 2, 2025 09:11
@jonathanKingston jonathanKingston merged commit c7157b5 into main Apr 2, 2025
10 of 14 checks passed
@jonathanKingston jonathanKingston deleted the jkt/getFeatureSettingEnabledTests branch April 2, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madblex madblex madblex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathanKingston @madblex