Add Image Captcha Solver #1612

brianhall · 2025-04-03T13:18:01Z

Asana Task/Github Issue:

Description

Asana: https://app.asana.com/0/72649045549333/1209395858706166/f

Testing Steps

See Asana

Checklist

Please tick all that apply:

I have tested this change locally
I have tested this change locally in all supported browsers
This change will be visible to users
I have added automated tests that cover this change
I have ensured the change is gated by config
This change was covered by a ship review
This change was covered by a tech design
Any dependent config has been merged

netlify · 2025-04-03T13:18:19Z

✅ Deploy Preview for content-scope-scripts ready!

Name	Link
🔨 Latest commit	`07f4cda`
🔍 Latest deploy log	https://app.netlify.com/sites/content-scope-scripts/deploys/67f7ac4a60545500089c1b45
😎 Deploy Preview	https://deploy-preview-1612--content-scope-scripts.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2025-04-03T13:18:31Z

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Branch Name: pr-releases/pr-1612
Commit Hash: 06a3717d25ac757d7b265e5faac7cd38d4dfe02f
Last Updated: April 10, 2025 at 11:32:53 AM UTC
Install Command: npm i github:duckduckgo/content-scope-scripts#06a3717d25ac757d7b265e5faac7cd38d4dfe02f

Please use the above install command to update to the latest version.

github-actions · 2025-04-03T13:18:44Z

[Beta] Generated file diff

Time updated: Thu, 10 Apr 2025 11:33:03 GMT

Android

    - android/brokerProtection.js

File has changed

Integration

    - integration/contentScope.js

File has changed

Windows

    - windows/contentScope.js

File has changed

Apple

    - dist/contentScopeIsolated.js

File has changed

injected/src/features/broker-protection/captcha-services/providers/image.js

injected/src/features/broker-protection/captcha-services/utils/token.js

brianhall · 2025-04-04T11:23:36Z

Not sure why the auto respond PR steps are failing…

madblex

LGTM! No blockers, just some recommendations

injected/src/features/broker-protection/captcha-services/providers/image.js

injected/src/features/broker-protection/captcha-services/utils/image.js

injected/src/features/broker-protection/captcha-services/utils/token.js

madblex · 2025-04-10T06:30:12Z

Not sure why the auto respond PR steps are failing…

@brianhall I pushed a commit to fix it, hope that's ok.

brianhall · 2025-04-10T08:20:21Z

Not sure why the auto respond PR steps are failing…

@brianhall I pushed a commit to fix it, hope that's ok.

For sure. My editor must have stripped the extensions out, thank you!

madblex

LGTM with one nit

injected/src/features/broker-protection/captcha-services/utils/token.js

jonathanKingston

Just for code ownership r+ maybe it's re-required after the file changes.

brianhall added 3 commits March 27, 2025 16:53

First pass - image captcha

ecd850b

Add SVG converter

4a1fecb

Feature complete

c301ea4

brianhall added 5 commits April 3, 2025 15:28

Add docs

30d989c

Types

51630f4

Fix up types

d8611b8

Fix up linting issues

eb80455

Merge branch 'main' into bhall/add-image-captcha-provider

49e0a94

brianhall commented Apr 3, 2025

View reviewed changes

injected/src/features/broker-protection/captcha-services/providers/image.js Outdated Show resolved Hide resolved

brianhall added 4 commits April 3, 2025 18:36

Lint fixes

47e16cc

Merge branch 'main' into bhall/add-image-captcha-provider

e26f1eb

Minor clean-up

cbe6022

Add tests

2b4eaab

brianhall commented Apr 4, 2025

View reviewed changes

injected/src/features/broker-protection/captcha-services/utils/token.js Outdated Show resolved Hide resolved

brianhall added 3 commits April 4, 2025 13:00

Lint fix

8565781

Fix netlify

5c23ea3

Revert netlify fix

746626f

brianhall marked this pull request as ready for review April 4, 2025 11:21

brianhall requested review from shakyShane and a team as code owners April 4, 2025 11:21

madblex previously approved these changes Apr 8, 2025

View reviewed changes

Code Review Feedback

fbcbb89

brianhall dismissed madblex’s stale review via fbcbb89 April 9, 2025 15:09

Add type checks for input

85a61aa

madblex reviewed Apr 10, 2025

View reviewed changes

injected/src/features/broker-protection/captcha-services/utils/token.js Outdated Show resolved Hide resolved

fix: exports issue

c59df85

brianhall added 3 commits April 10, 2025 10:26

Fix else statement

d842d36

Merge branch 'main' into bhall/add-image-captcha-provider

9b906ac

Merge branch 'main' into bhall/add-image-captcha-provider

0148732

madblex previously approved these changes Apr 10, 2025

View reviewed changes

injected/src/features/broker-protection/captcha-services/utils/token.js Outdated Show resolved Hide resolved

injected/src/features/broker-protection/captcha-services/utils/token.js Outdated Show resolved Hide resolved

Group success conditions

07f4cda

brianhall dismissed madblex’s stale review via 07f4cda April 10, 2025 11:32

madblex approved these changes Apr 10, 2025

View reviewed changes

jonathanKingston approved these changes Apr 10, 2025

View reviewed changes

brianhall merged commit f467cc3 into main Apr 10, 2025
17 checks passed

brianhall deleted the bhall/add-image-captcha-provider branch April 10, 2025 11:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add Image Captcha Solver #1612

Add Image Captcha Solver #1612

Uh oh!

brianhall commented Apr 3, 2025 •

edited

Loading

Uh oh!

netlify bot commented Apr 3, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Apr 3, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Apr 3, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

brianhall commented Apr 4, 2025

Uh oh!

madblex left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

madblex commented Apr 10, 2025

Uh oh!

brianhall commented Apr 10, 2025 •

edited

Loading

Uh oh!

madblex left a comment

Uh oh!

Uh oh!

Uh oh!

jonathanKingston left a comment

Uh oh!

Uh oh!

Uh oh!

Add Image Captcha Solver #1612

Add Image Captcha Solver #1612

Uh oh!

Conversation

brianhall commented Apr 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing Steps

Checklist

Uh oh!

netlify bot commented Apr 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for content-scope-scripts ready!

Uh oh!

github-actions bot commented Apr 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Temporary Branch Update

Uh oh!

github-actions bot commented Apr 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

[Beta] Generated file diff

Uh oh!

Uh oh!

Uh oh!

brianhall commented Apr 4, 2025

Uh oh!

madblex left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

madblex commented Apr 10, 2025

Uh oh!

brianhall commented Apr 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

madblex left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jonathanKingston left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

brianhall commented Apr 3, 2025 •

edited

Loading

netlify bot commented Apr 3, 2025 •

edited

Loading

github-actions bot commented Apr 3, 2025 •

edited

Loading

github-actions bot commented Apr 3, 2025 •

edited

Loading

brianhall commented Apr 10, 2025 •

edited

Loading