Skip to content

Setting of document for tracker analysis #1613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2025

Conversation

jonathanKingston
Copy link
Contributor

@jonathanKingston jonathanKingston commented Apr 7, 2025

Asana Task/Github Issue: duckduckgo/duckduckgo-privacy-extension#3015

Description

For assist with: duckduckgo/duckduckgo-privacy-extension#3015

Allows setting of the document as used in the cookie testing in the extension when it's used in a node environment with jsdom.

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Copy link

netlify bot commented Apr 7, 2025

Deploy Preview for content-scope-scripts failed.

Name Link
🔨 Latest commit a7b5c1e
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/67f3cd03a3f15a00081fed0f

Copy link

github-actions bot commented Apr 7, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Apr 7, 2025

[Beta] Generated file diff

Time updated: Mon, 07 Apr 2025 13:03:54 GMT

Android
    - android/autofillPasswordImport.js
  • android/brokerProtection.js
  • android/contentScope.js

File has changed

Chrome-mv3
    - chrome-mv3/inject.js

File has changed

Firefox
    - firefox/inject.js

File has changed

Integration
    - integration/contentScope.js

File has changed

Windows
    - windows/contentScope.js

File has changed

Apple
    - dist/contentScope.js
  • dist/contentScopeIsolated.js

File has changed

@jonathanKingston jonathanKingston force-pushed the jkt/setGlobalForTrackerOrigin branch 2 times, most recently from dc4965f to a407f3a Compare April 7, 2025 09:19
@jonathanKingston jonathanKingston force-pushed the jkt/setGlobalForTrackerOrigin branch from a407f3a to ca54507 Compare April 7, 2025 09:22
@jonathanKingston jonathanKingston marked this pull request as ready for review April 7, 2025 09:25
@jonathanKingston jonathanKingston requested a review from a team as a code owner April 7, 2025 09:25
dbajpeyi
dbajpeyi previously approved these changes Apr 7, 2025
Copy link
Contributor

@dbajpeyi dbajpeyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, other than the minor comment.

dbajpeyi
dbajpeyi previously approved these changes Apr 7, 2025
@jonathanKingston jonathanKingston merged commit 627b5e4 into main Apr 7, 2025
12 of 16 checks passed
@jonathanKingston jonathanKingston deleted the jkt/setGlobalForTrackerOrigin branch April 7, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants