Adapt Activity & Privacy Stats widgets for ads and trackers #1621

noisysocks · 2025-04-09T04:36:34Z

Asana Task/Github Issue: https://app.asana.com/0/1209121419454298/1209865676528005/f

Description

`adBlocking.enabled = false`	`adBlocking.enabled = true`

Updates the Activity and Privacy Stats widgets to support a variation where browser protections include ad blocking as well as tracker protection.

Updates UI text, icons, and styles based on whether the browser blocks just trackers or ads and trackers.
Introduces a adBlocking feature flag to NewTabPageSettings to control display.
Updates tests and mock data accordingly.

Testing Steps

Navigate to:

Checklist

Please tick all that apply:

I have tested this change locally
I have tested this change locally in all supported browsers
This change will be visible to users
I have added automated tests that cover this change
I have ensured the change is gated by config
This change was covered by a ship review
This change was covered by a tech design
Any dependent config has been merged

github-actions · 2025-04-09T04:37:04Z

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Branch Name: pr-releases/pr-1621
Commit Hash: 0fd295537c5950a7e9dceb173f8c80a2f7f641a8
Last Updated: April 15, 2025 at 10:42:59 PM UTC
Install Command: npm i github:duckduckgo/content-scope-scripts#0fd295537c5950a7e9dceb173f8c80a2f7f641a8

Please use the above install command to update to the latest version.

github-actions · 2025-04-09T04:37:15Z

[Beta] Generated file diff

Time updated: Tue, 15 Apr 2025 22:43:06 GMT

Integration

    - integration/pages/new-tab/dist/index.css

integration/pages/new-tab/dist/index.js
integration/pages/new-tab/locales/en/new-tab.json

File has changed

Windows

    - windows/pages/new-tab/dist/index.css

windows/pages/new-tab/dist/index.js
windows/pages/new-tab/locales/en/new-tab.json

File has changed

Apple

    - dist/pages/new-tab/dist/index.css

dist/pages/new-tab/dist/index.js
dist/pages/new-tab/locales/en/new-tab.json

File has changed

New Files

    - integration/pages/new-tab/icons/shield-green.svg

windows/pages/new-tab/icons/shield-green.svg
dist/pages/new-tab/icons/shield-green.svg

❌ File only exists in new changeset

netlify · 2025-04-09T04:37:18Z

✅ Deploy Preview for content-scope-scripts ready!

Name	Link
🔨 Latest commit	`135b3f0`
🔍 Latest deploy log	https://app.netlify.com/sites/content-scope-scripts/deploys/67fee0d31decac0008840d1e
😎 Deploy Preview	https://deploy-preview-1621--content-scope-scripts.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mgurgel

Looks excellent to me. The useTrackerType hook makes it easier to roll back the changes if the experiment is not successful. In fact, I wonder if it's worth creating separate components (e.g. ActivityHeadingAds and TrackerStatusAds) to make it easier to commit to one or the other once the experiment is done. We've been doing something similar in Duck Player to good results. Not a request, just a thought.

I agree with the choice of storing trackerType in activity config, but I'd still like to get Shane's sign-off on it when he's back.

special-pages/pages/new-tab/app/activity/ActivityProvider.js

noisysocks · 2025-04-11T05:40:39Z

I agree with the choice of storing trackerType in activity config, but I'd still like to get Shane's sign-off on it when he's back.

I may end up using a initResponse feature flag after all depending on outcome of https://app.asana.com/1/137249556945/project/0/task/1209958041601248.

noisysocks · 2025-04-14T01:40:34Z

I’ve made some significant changes here.

The PR now updates both the Activity and Privacy Stats widgets to support the variation where the browser blocks ads as well as trackers. (Before, only the Activity widget was updated.) This addresses an oversight in the original design, see https://app.asana.com/1/137249556945/project/0/task/1209958041601248.

Because more than one type of widget is now affected by this feature flag I think it makes sense to do the flagging in NewTabPageSettings instead of the per-widget config object.

I’ve made those changes, updated tests, and updated the PR description.

special-pages/pages/new-tab/readme.md

mgurgel

Looks good 👍 Over to @shakyShane for an architecture review

noisysocks · 2025-04-15T01:47:45Z

I tested this in the Windows app and it worked well but noticed that the subtitle line height and letter spacing was inconsistent with the Next Steps widget. I’ve tweaked it to be consistent:

shakyShane

Very nice work - my only points are the same as the other PR:

1: what's the plan with translations?
2: the PR should go green once my other fix is merged.

special-pages/pages/new-tab/readme.md

- Updates UI text, icons, and styles based on whether the browser blocks just trackers or ads and trackers. - Introduces a `trackerType` config option ('trackersOnly' or 'adsAndTrackers') to control the display. - Adds new translation strings and a green shield icon for the ads and trackers variant. - Updates tests and mock data accordingly.

This reverts commit 0049864.

noisysocks added enhancement New feature or request minor Increment the minor version when merged labels Apr 9, 2025

noisysocks requested review from shakyShane, mgurgel and a team as code owners April 9, 2025 04:36

noisysocks force-pushed the randerson/ads-and-trackers-copy branch 2 times, most recently from 0049864 to f1e8724 Compare April 9, 2025 04:51

mgurgel requested changes Apr 10, 2025

View reviewed changes

special-pages/pages/new-tab/app/activity/ActivityProvider.js Outdated Show resolved Hide resolved

noisysocks force-pushed the randerson/ads-and-trackers-copy branch from 935fd1c to 80596e8 Compare April 14, 2025 01:25

noisysocks changed the title ~~Adapt Activity widget for ads and trackers~~ Adapt Activity & Privacy Stats widgets for ads and trackers Apr 14, 2025

noisysocks requested a review from mgurgel April 14, 2025 01:49

noisysocks mentioned this pull request Apr 14, 2025

Ad blocking super branch #1631

Closed

mgurgel force-pushed the randerson/ads-and-trackers-copy branch from 593ae56 to b12de7d Compare April 14, 2025 16:04

mgurgel reviewed Apr 14, 2025

View reviewed changes

special-pages/pages/new-tab/readme.md Show resolved Hide resolved

mgurgel previously approved these changes Apr 14, 2025

View reviewed changes

noisysocks dismissed mgurgel’s stale review via 1822ae6 April 15, 2025 01:43

shakyShane reviewed Apr 15, 2025

View reviewed changes

special-pages/pages/new-tab/readme.md Outdated Show resolved Hide resolved

mgurgel mentioned this pull request Apr 15, 2025

Add ad blocking variants to v3 onboarding #1623

Merged

8 tasks

noisysocks force-pushed the randerson/ads-and-trackers-copy branch from 1822ae6 to 97dde26 Compare April 15, 2025 09:55

shakyShane approved these changes Apr 15, 2025

View reviewed changes

noisysocks added 4 commits April 16, 2025 08:42

Empty Netlify build cache

d11d51b

Revert "Empty Netlify build cache"

6c0ff3b

This reverts commit 0049864.

Update 'no recent history' placeholder copy

600dc8c

noisysocks added 4 commits April 16, 2025 08:42

Adapt Privacy Stats widget for ads and trackers

ad6237c

Add new tab URL test parameters documentation

51497f8

Tweak subtitle styling to be consistent with Next Steps widget

0168f41

Fix references to 'onboarding' in param docs

135b3f0

noisysocks force-pushed the randerson/ads-and-trackers-copy branch from cabe589 to 135b3f0 Compare April 15, 2025 22:42

noisysocks merged commit c8a9f21 into main Apr 15, 2025
13 checks passed

noisysocks deleted the randerson/ads-and-trackers-copy branch April 15, 2025 23:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Adapt Activity & Privacy Stats widgets for ads and trackers #1621

Adapt Activity & Privacy Stats widgets for ads and trackers #1621

Uh oh!

noisysocks commented Apr 9, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Apr 9, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Apr 9, 2025 •

edited

Loading

Uh oh!

netlify bot commented Apr 9, 2025 •

edited

Loading

Uh oh!

mgurgel left a comment •

edited

Loading

Uh oh!

Uh oh!

noisysocks commented Apr 11, 2025

Uh oh!

noisysocks commented Apr 14, 2025

Uh oh!

Uh oh!

mgurgel left a comment

Uh oh!

noisysocks commented Apr 15, 2025

Uh oh!

shakyShane left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Adapt Activity & Privacy Stats widgets for ads and trackers #1621

Adapt Activity & Privacy Stats widgets for ads and trackers #1621

Uh oh!

Conversation

noisysocks commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing Steps

Checklist

Uh oh!

github-actions bot commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Temporary Branch Update

Uh oh!

github-actions bot commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

[Beta] Generated file diff

Uh oh!

netlify bot commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for content-scope-scripts ready!

Uh oh!

mgurgel left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

noisysocks commented Apr 11, 2025

Uh oh!

noisysocks commented Apr 14, 2025

Uh oh!

Uh oh!

mgurgel left a comment

Choose a reason for hiding this comment

Uh oh!

noisysocks commented Apr 15, 2025

Uh oh!

shakyShane left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

noisysocks commented Apr 9, 2025 •

edited

Loading

github-actions bot commented Apr 9, 2025 •

edited

Loading

github-actions bot commented Apr 9, 2025 •

edited

Loading

netlify bot commented Apr 9, 2025 •

edited

Loading

mgurgel left a comment •

edited

Loading