Skip to content

Add Cloudflare Turnstile Support #1633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Apr 22, 2025
Merged

Conversation

brianhall
Copy link
Contributor

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/72649045549333/task/1209329834965899?focus=true

Description

Adds CloudFlare Turnstile solving to PIR.

Testing Steps

  • See Asana

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Copy link

netlify bot commented Apr 15, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit d3f00eb
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/6807aabbe93f010008162bc3
😎 Deploy Preview https://deploy-preview-1633--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Apr 15, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Apr 15, 2025

[Beta] Generated file diff

Time updated: Tue, 22 Apr 2025 14:42:51 GMT

Android
    - android/brokerProtection.js

File has changed

Integration
    - integration/contentScope.js

File has changed

Windows
    - windows/contentScope.js

File has changed

Apple
    - dist/contentScopeIsolated.js

File has changed

@brianhall brianhall marked this pull request as ready for review April 17, 2025 17:25
@brianhall brianhall requested review from shakyShane, madblex and a team as code owners April 17, 2025 17:25
Copy link
Contributor

@madblex madblex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM generally, very nicely done! 👏

Just one comment I'd like to get addressed: #1633 (comment), the rest are suggestions / nit.

Holding off approval until e2e testing is done successfully!

@brianhall brianhall requested a review from a team as a code owner April 21, 2025 12:12
Copy link
Contributor

@madblex madblex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brianhall brianhall merged commit bba5ecc into main Apr 22, 2025
14 checks passed
@brianhall brianhall deleted the bhall/add-cloudflare-provider branch April 22, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants