-
Notifications
You must be signed in to change notification settings - Fork 28
Add Cloudflare Turnstile Support #1633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for content-scope-scripts ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Tue, 22 Apr 2025 14:42:51 GMT Android
File has changed Integration
File has changed Windows
File has changed Apple
File has changed |
…instance with PirError
injected/src/features/broker-protection/captcha-services/captcha.service.js
Show resolved
Hide resolved
injected/integration-test/broker-protection-tests/broker-protection-captcha.spec.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM generally, very nicely done! 👏
Just one comment I'd like to get addressed: #1633 (comment), the rest are suggestions / nit.
Holding off approval until e2e testing is done successfully!
injected/integration-test/test-pages/broker-protection/pages/cloudflare-captcha.html
Show resolved
Hide resolved
injected/src/features/broker-protection/captcha-services/captcha.service.js
Show resolved
Hide resolved
injected/src/features/broker-protection/captcha-services/utils/callback.js
Outdated
Show resolved
Hide resolved
injected/src/features/broker-protection/captcha-services/providers/registry.js
Outdated
Show resolved
Hide resolved
injected/src/features/broker-protection/captcha-services/providers/cloudflare-turnstile.js
Show resolved
Hide resolved
injected/src/features/broker-protection/captcha-services/providers/cloudflare-turnstile.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/72649045549333/task/1209329834965899?focus=true
Description
Adds CloudFlare Turnstile solving to PIR.
Testing Steps
Checklist
Please tick all that apply: