Skip to content

injected: fixing flaky duckplayer tests #1639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 21, 2025

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Apr 18, 2025

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1201141132935289/task/1209702368219524?focus=true

Description

  • This test is causing a lot of retries and noisy PR diffs.

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

netlify bot commented Apr 18, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 0499eac
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/6802ba9425937600084e06f0
😎 Deploy Preview https://deploy-preview-1639--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Apr 18, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Apr 18, 2025

[Beta] Generated file diff

Time updated: Fri, 18 Apr 2025 20:49:03 GMT

@shakyShane shakyShane marked this pull request as ready for review April 18, 2025 13:56
@shakyShane shakyShane requested a review from a team as a code owner April 18, 2025 13:56
@shakyShane shakyShane merged commit df78426 into main Apr 21, 2025
14 checks passed
@shakyShane shakyShane deleted the 04-18-injected_fixing_flaky_duckplayer_tests branch April 21, 2025 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants