Onboarding: Send set*() messages to native apps when step is skipped #1648
+147
−53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1209121419454298/task/1209906221282239
Description
Modifies the Onboarding special page so that the
setBookmarksBar
,setSessionRestore
,setShowHomeButton
, andsetAdBlocking
messages are sent withparams.enabled = false
when the user clicks Skip during onboarding. This allows the native apps to fire a pixel when the user skips one of these, if desired.The
requestDockOptIn
,requestImport
, andrequestSetAsDefault
messages remain as-is. These aren’t reversible actions so it doesn’t make sense to fire a message withparams.enabled = false
.Testing Steps
unhandled notification
warnings in the console withparams.enabled = false
when skipping:Checklist
Please tick all that apply: