Skip to content

Conditional experiment matching #1661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 14, 2025
Merged

Conversation

jonathanKingston
Copy link
Contributor

@jonathanKingston jonathanKingston commented Apr 30, 2025

Asana Task/Github Issue: https://app.asana.com/1/137249556945/task/1210112276693076?focus=true

Description

Testing Steps

  • Testing will happen in conjunction with the experiment rollout code on platforms.
  • The most important here is to validate that is isolated to not impact existing patches.

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Copy link

netlify bot commented Apr 30, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit a9f4605
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/68248431143d000008e1ca0a
😎 Deploy Preview https://deploy-preview-1661--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Apr 30, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Apr 30, 2025

[Beta] Generated file diff

Time updated: Wed, 14 May 2025 11:54:13 GMT

Android
    - android/autofillPasswordImport.js
  • android/brokerProtection.js
  • android/contentScope.js

File has changed

Chrome-mv3
    - chrome-mv3/inject.js

File has changed

Firefox
    - firefox/inject.js

File has changed

Integration
    - integration/contentScope.js

File has changed

Windows
    - windows/contentScope.js

File has changed

Apple
    - dist/contentScope.js
  • dist/contentScopeIsolated.js

File has changed

@jonathanKingston jonathanKingston force-pushed the jkt/c-s-s-experiments branch from 10be601 to bd11af7 Compare May 13, 2025 12:12
@jonathanKingston jonathanKingston force-pushed the jkt/c-s-s-experiments branch from bd11af7 to c012c4e Compare May 13, 2025 12:12
@jonathanKingston jonathanKingston changed the title PoC conditional experiment matching Conditional experiment matching May 13, 2025
@jonathanKingston jonathanKingston requested a review from dbajpeyi May 13, 2025 13:11
@jonathanKingston jonathanKingston marked this pull request as ready for review May 14, 2025 11:51
@jonathanKingston jonathanKingston requested a review from a team as a code owner May 14, 2025 11:51
@jonathanKingston jonathanKingston merged commit 95042fc into main May 14, 2025
13 checks passed
@jonathanKingston jonathanKingston deleted the jkt/c-s-s-experiments branch May 14, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants