Skip to content

Add query param color=white to #1662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2025
Merged

Conversation

mgurgel
Copy link
Contributor

@mgurgel mgurgel commented May 1, 2025

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1207252092703676/task/1210128066798031?focus=true

Description

YouTube's seemingly rolling out a new embedded player UI which is used in Duck Player. We discovered that adding a URL param (color=white) will force the YouTube player to use the legacy UI instead of the new player.

Testing Steps

  • Run this branch of C-S-S on an Android or iOS build
  • Open Duck Player on any video
  • Use Safari or Chrome to inspect the Duck Player window
  • Confirm that the iframe has a src attribute that includes the query param color=white . You can run this on the console to confirm document.querySelector('iframe').src.includes('color=white');
  • Confirm that the player interface looks like this
image

and not like this

image

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@mgurgel mgurgel requested review from shakyShane and a team as code owners May 1, 2025 11:37
Copy link

github-actions bot commented May 1, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented May 1, 2025

[Beta] Generated file diff

Time updated: Thu, 01 May 2025 11:40:22 GMT

Android
    - android/pages/duckplayer/dist/index.js

File has changed

Integration
    - integration/pages/duckplayer/dist/index.js

File has changed

Windows
    - windows/pages/duckplayer/dist/index.js

File has changed

Apple
    - dist/pages/duckplayer/dist/index.js
  • dist/pages/duckplayer/index.html

File has changed

Copy link

netlify bot commented May 1, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit d82d002
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/68135d7d39d5060008fcb2b9
😎 Deploy Preview https://deploy-preview-1662--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mgurgel
Copy link
Contributor Author

mgurgel commented May 1, 2025

@shakyShane I'm checking whether we can roll this change out to desktop too.

@mgurgel
Copy link
Contributor Author

mgurgel commented May 2, 2025

Tested on desktop. No issues I could see.
image

@mgurgel mgurgel merged commit 193bd25 into main May 2, 2025
14 checks passed
@mgurgel mgurgel deleted the mgurgel/duckplayer-youtube-theme branch May 2, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants