Skip to content

windows: enabled message bridge #1663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 12, 2025
Merged

windows: enabled message bridge #1663

merged 3 commits into from
May 12, 2025

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented May 2, 2025

Asana Task/Github Issue:
https://app.asana.com/1/137249556945/project/12988952642567/task/1208697679300714?focus=true

Description

Enabled on windows

Testing Steps

  • Tested by the Windows team, no additional code changes required.

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Copy link

netlify bot commented May 2, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 096279a
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/6821e05e317ce500081c6dc9
😎 Deploy Preview https://deploy-preview-1663--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shakyShane
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented May 2, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented May 2, 2025

[Beta] Generated file diff

Time updated: Mon, 12 May 2025 11:50:30 GMT

Android
    - android/autofillPasswordImport.js
  • android/brokerProtection.js
  • android/contentScope.js

File has changed

Chrome-mv3
    - chrome-mv3/inject.js

File has changed

Firefox
    - firefox/inject.js

File has changed

Integration
    - integration/contentScope.js

File has changed

Windows
    - windows/contentScope.js

File has changed

Apple
    - dist/contentScope.js
  • dist/contentScopeIsolated.js

File has changed

@petevb
Copy link
Contributor

petevb commented May 7, 2025

@shakyShane I notice this is still draft. What's your ETA for getting these changes into main please? We're targeting this week for the feature.

@shakyShane shakyShane marked this pull request as ready for review May 12, 2025 11:49
@shakyShane shakyShane requested review from a team as code owners May 12, 2025 11:49
@shakyShane
Copy link
Contributor Author

Tested on windows + approved in security review, merging!

@shakyShane shakyShane merged commit 8f6af53 into main May 12, 2025
15 checks passed
@shakyShane shakyShane deleted the shane/windows-bridge branch May 12, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants