Skip to content

Onboarding: Skip Duck Player step when ad blocking is enabled #1673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025

Conversation

noisysocks
Copy link
Contributor

@noisysocks noisysocks commented May 8, 2025

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1209121419454298/task/1210051898870594?focus=true

Description

Skip the Duck Player step in the onboarding flow when the user enables ad blocking.

Testing Steps

  1. Navigate to https://deploy-preview-1673--content-scope-scripts.netlify.app/build/pages/onboarding/?adBlocking=enabled&platform=windows.
  2. Select “Turn on Enhanced Ad Blocking” when prompted.
  3. Note that Duck Player step does not appear after clicking Next.
  4. Repeat, but this time select “Skip” when prompted to enable ad blocking.
  5. Note that Duck Player step appears after clicking Next.

Repeat steps with https://deploy-preview-1673--content-scope-scripts.netlify.app/build/pages/onboarding/?adBlocking=youtube&platform=windows

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@noisysocks noisysocks added the enhancement New feature or request label May 8, 2025
@noisysocks noisysocks requested review from shakyShane, mgurgel and a team as code owners May 8, 2025 05:51
Copy link

netlify bot commented May 8, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 8d6f627
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/681c464ef05b780008e1336f
😎 Deploy Preview https://deploy-preview-1673--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented May 8, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented May 8, 2025

[Beta] Generated file diff

Time updated: Thu, 08 May 2025 05:51:55 GMT

Integration
    - integration/pages/onboarding/dist/index.js
  • integration/pages/onboarding/locales/en/onboarding.json

File has changed

Windows
    - windows/pages/onboarding/dist/index.js
  • windows/pages/onboarding/locales/en/onboarding.json

File has changed

Apple
    - dist/pages/onboarding/dist/index.js
  • dist/pages/onboarding/locales/en/onboarding.json

File has changed

@noisysocks noisysocks added the minor Increment the minor version when merged label May 8, 2025
@noisysocks noisysocks merged commit 4da96eb into main May 8, 2025
18 checks passed
@noisysocks noisysocks deleted the randerson/skip-duck-player branch May 8, 2025 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants