Skip to content

Onboarding: Update YouTube feature description for ad blocking experiment #1674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025

Conversation

noisysocks
Copy link
Contributor

@noisysocks noisysocks commented May 8, 2025

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1209121419454298/task/1210051898870594?focus=true

Description

Default With ad blocking experiment enabled
127 0 0 1_8000__platform=windows page=makeDefaultSingle(iPad Air) 127 0 0 1_8000__platform=windows page=makeDefaultSingle adBlocking=enabled(iPad Air)

Updates the copy of the YouTube row in the “Make DuckDuckGo Your Default” feature grid shown during onboarding when the ad blocking experiment is enabled.

Testing Steps

  1. Navigate to https://deploy-preview-1674--content-scope-scripts.netlify.app/build/pages/onboarding/?adBlocking=enabled&platform=windows&page=makeDefaultSingle.
  2. Note that copy in last row is “Watch YouTube ad-free”.
  3. Navigate to https://deploy-preview-1674--content-scope-scripts.netlify.app/build/pages/onboarding/?adBlocking=youtube&platform=windows&page=makeDefaultSingle.
  4. Note that copy in last row is “Watch YouTube ad-free”.
  5. Navigate to https://deploy-preview-1674--content-scope-scripts.netlify.app/build/pages/onboarding/?platform=windows&page=makeDefaultSingle.
  6. Note that copy in last row is “Play YouTube without target ads”, as it is in main.

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@noisysocks noisysocks requested review from shakyShane, mgurgel and a team as code owners May 8, 2025 05:55
@noisysocks noisysocks added the enhancement New feature or request label May 8, 2025
Copy link

netlify bot commented May 8, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit a48f927
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/681c4dbdaf2a6900085fbdcb
😎 Deploy Preview https://deploy-preview-1674--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@noisysocks noisysocks added the minor Increment the minor version when merged label May 8, 2025
Copy link

github-actions bot commented May 8, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented May 8, 2025

[Beta] Generated file diff

Time updated: Thu, 08 May 2025 06:23:32 GMT

Integration
    - integration/pages/onboarding/dist/index.js
  • integration/pages/onboarding/locales/en/onboarding.json

File has changed

Windows
    - windows/pages/onboarding/dist/index.js
  • windows/pages/onboarding/locales/en/onboarding.json

File has changed

Apple
    - dist/pages/onboarding/dist/index.js
  • dist/pages/onboarding/locales/en/onboarding.json

File has changed

@noisysocks noisysocks force-pushed the randerson/update-youtube-copy branch from 14b297a to a48f927 Compare May 8, 2025 06:22
@noisysocks noisysocks merged commit 30cf67e into main May 8, 2025
13 checks passed
@noisysocks noisysocks deleted the randerson/update-youtube-copy branch May 8, 2025 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants