Skip to content

Onboarding: Move ad blocking setting row to the last position #1687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025

Conversation

noisysocks
Copy link
Contributor

@noisysocks noisysocks commented May 14, 2025

Asana Task/Github Issue: https://app.asana.com/1/137249556945/task/1209984478183529/comment/1210246117664575?focus=true

Description

Moves the ad blocking settings row to the last position per Jack’s comment above.

Screenshot 2025-05-14 at 11 31 20

Testing Steps

  1. Browse to https://deploy-preview-1687--content-scope-scripts.netlify.app/build/pages/onboarding/?adBlocking=enabled and move through the onboarding flow.
  2. Browse to https://deploy-preview-1687--content-scope-scripts.netlify.app/build/pages/onboarding/?adBlocking=youtube and move through the onboarding flow.

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@noisysocks noisysocks requested review from shakyShane, mgurgel and a team as code owners May 14, 2025 01:32
@noisysocks noisysocks added enhancement New feature or request minor Increment the minor version when merged labels May 14, 2025
Copy link

netlify bot commented May 14, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 626c15d
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/6823f2bfbbc760000836c997
😎 Deploy Preview https://deploy-preview-1687--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@noisysocks noisysocks changed the title Move ad blocking setting row to the last position Onboarding: Move ad blocking setting row to the last position May 14, 2025
Copy link

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

[Beta] Generated file diff

Time updated: Wed, 14 May 2025 01:33:23 GMT

Integration
    - integration/pages/onboarding/dist/index.js

File has changed

Windows
    - windows/pages/onboarding/dist/index.js

File has changed

Apple
    - dist/pages/onboarding/dist/index.js

File has changed

Copy link
Contributor

@mgurgel mgurgel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I right that this still needs coordinating with Windows so that the correct order is passed into initialSetup?

@shakyShane
Copy link
Contributor

It looks like this is just updating tests etc - but since the data comes from the native side, this can be merged safely 💪🏻

@noisysocks
Copy link
Contributor Author

Yeah Windows app would need to pass in the correct order. I’ll make sure Randy is aware.

@noisysocks noisysocks merged commit 26fad2e into main May 14, 2025
19 checks passed
@noisysocks noisysocks deleted the randerson/move-ad-blocking-row branch May 14, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants