Reland Display Click to Load placeholders on demand #296
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes were landed and reverted last week, since some of the
integration tests started failing. But it turned out, that those failures
were just down to Puppeteer reporting blocked requests differently if
the corresponding elements are removed from the DOM very quickly.
See duckduckgo/duckduckgo-privacy-extension@8b5d389
The original commit message:
Historically, the Click to Load placeholders were only drawn once at
the point page load completed. That had two problems:
took a long time to load fully.
blocked content was only created after page load had finished.
To fix that, let's display the placeholders when instructed by the
platform using a "displayClickToLoadPlaceholders" update message.
Let's also restructure the response messages, so that they can be
clearly distinguished.