Improve element hiding empty check to avoid potentially hiding visible content #319
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana link: https://app.asana.com/0/1203557590179903/1204090946699947/f
Corresponding privacy test page update: duckduckgo/privacy-test-pages#130
While we try to be precise in the selector rules we use for element hiding, we've run into a few cases now where we accidentally hid visible content that matched an ad selector. This PR adds several guardrails to prevent hiding visible content even when elements match common ad selectors.
Specifically, this PR:
<embed>
,<object>
,<audio>
, and<map>
<form>
,<input>
,<textarea>
,<select>
,<option>
, and<button>