Skip to content

Replace private method support with _ for now #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2023
Merged

Replace private method support with _ for now #321

merged 1 commit into from
Mar 15, 2023
+15 −15

Conversation

jonathanKingston
Copy link
Contributor

This fixes a syntax issue with Android that we're having.

joshliebe
joshliebe approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@joshliebe joshliebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathanKingston jonathanKingston merged commit 8cf2a29 into main Mar 15, 2023
@jonathanKingston jonathanKingston deleted the jkt/replacePrivateMethodsRuntime branch March 15, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshliebe joshliebe joshliebe approved these changes

@shakyShane shakyShane Awaiting requested review from shakyShane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathanKingston @joshliebe