Skip to content

Remove the need for the build replacements for all non chrome platforms #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2023
Merged

Remove the need for the build replacements for all non chrome platforms #344

merged 1 commit into from
Mar 25, 2023

Conversation

jonathanKingston
Copy link
Contributor

@jonathanKingston jonathanKingston commented Mar 25, 2023 •
edited
Loading

Replace the need for string replacement of the code for all platforms except MV2 Chrome.

shakyShane
shakyShane approved these changes Mar 25, 2023
View reviewed changes
Copy link
Contributor

@shakyShane shakyShane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect

@jonathanKingston jonathanKingston merged commit 0c10413 into main Mar 25, 2023
@jonathanKingston jonathanKingston deleted the jkt/removeBuildReplacements branch March 25, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shakyShane shakyShane shakyShane approved these changes

@q71114 q71114 Awaiting requested review from q71114

@szanto90balazs szanto90balazs Awaiting requested review from szanto90balazs

@kzar kzar Awaiting requested review from kzar

@sammacbeth sammacbeth Awaiting requested review from sammacbeth

@joshliebe joshliebe Awaiting requested review from joshliebe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathanKingston @shakyShane