Remove unused (and broken) hideTrackingElement Click to Load code path #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzar
force-pushed
the
fix-ctl-youtube-placeholders-p1
branch
4 times, most recently
from
81a45ad to
e1063e4
Compare
franfaccin
reviewed
Mar 28, 2023
franfaccin
reviewed
Mar 28, 2023
kzar
force-pushed
the
fix-ctl-youtube-placeholders-p1
branch
3 times, most recently
from
6d9e854 to
74106a9
Compare
The hideTrackingElement code path was originally intended for use with YouTube Click to Load placeholders. The thinking was to keep the original YouTube video elements on the page, in case the website referenced the original element when creating a video. Unfortunately that didn't work out, since keeping the original element on the page caused problems such as duplicate placeholders being displayed. We already stopped using that code path, let's tidy things up and remove it. While we're at it, let's fix the element resizing for Chrome MV3 builds. It turns out that when the declarativeNetRequest API blocks an element, the element is automatically "collapsed" (hidden). When this happens, getBoundingClientRect() considers the element to have a width and height of 0. Fall back to getComputedStyle when that happens.
kzar
force-pushed
the
fix-ctl-youtube-placeholders-p1
branch
from
74106a9 to
5a74de1
Compare
franfaccin
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hideTrackingElement code path was originally intended for use with
YouTube Click to Load placeholders. The thinking was to keep the
original YouTube video elements on the page, in case the website
referenced the original element when creating a video.
Unfortunately that didn't work out, since keeping the original element
on the page caused problems such as duplicate placeholders being
displayed. We already stopped using that code path, let's tidy things
up and remove it.
Testing notes