Skip to content

Add Android messaging integration #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Apr 6, 2023

Conversation

joshliebe
Copy link
Contributor

https://app.asana.com/0/0/1204325992866076/f

Adds the messaging integration for sending and receiving messages from Android.

@joshliebe joshliebe requested a review from kzar April 5, 2023 09:55
Copy link
Contributor

@kzar kzar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, a few more suggestions

@joshliebe joshliebe requested a review from kzar April 5, 2023 16:47
kzar
kzar previously approved these changes Apr 5, 2023
Copy link
Contributor

@kzar kzar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % One nit

Copy link
Contributor

@kzar kzar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshliebe joshliebe merged commit 2aa9766 into main Apr 6, 2023
@joshliebe joshliebe deleted the josh/add-android-messaging-integration branch April 6, 2023 10:13
marcosholgado added a commit that referenced this pull request Apr 7, 2023
jonathanKingston pushed a commit that referenced this pull request Apr 7, 2023
joshliebe added a commit that referenced this pull request Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants