Skip to content

Use inline statements for variable declaration #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 6, 2023
Merged

Use inline statements for variable declaration #387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c66d53f
Clean indenting of generated code
jonathanKingston Apr 5, 2023
e4b0981
Alpha ident generation
jonathanKingston Apr 5, 2023
4ff7c50
Use inline statements for variable declaration
jonathanKingston Apr 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions src/features/runtime-checks/script-overload.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,12 +92,7 @@ function stringifyScope (scope, scopePath) {
if (value instanceof Map) {
const proxyName = getOrGenerateIdentifier(['_proxyFor_', varOutName])
output += `
let ${proxyName}
if (${scopePath.join('?.')}?.${key} === undefined) {
${proxyName} = Object.bind(null);
} else {
${proxyName} = ${scopePath.join('.')}.${key};
}
let ${proxyName} = ${scopePath.join('?.')}?.${key} ? ${scopePath.join('.')}.${key} : Object.bind(null);
`
const keys = Array.from(value.keys())
output += stringifyScope(value, [...scopePath, key])
Expand Down
42 changes: 6 additions & 36 deletions unit-test/script-overload-snapshots/out/1.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,38 +21,13 @@
}
})
}
let _ddg_b
if (parentScope?.navigator === undefined) {
_ddg_b = Object.bind(null);
} else {
_ddg_b = parentScope.navigator;
}
let _ddg_b = parentScope?.navigator ? parentScope.navigator : Object.bind(null);
let _ddg_c = "testingThisOut";
let _ddg_e
if (parentScope?.navigator?.mediaSession === undefined) {
_ddg_e = Object.bind(null);
} else {
_ddg_e = parentScope.navigator.mediaSession;
}
let _ddg_e = parentScope?.navigator?.mediaSession ? parentScope.navigator.mediaSession : Object.bind(null);
let _ddg_f = "playing";
let _ddg_h
if (parentScope?.navigator?.mediaSession?.doesNotExist === undefined) {
_ddg_h = Object.bind(null);
} else {
_ddg_h = parentScope.navigator.mediaSession.doesNotExist;
}
let _ddg_j
if (parentScope?.navigator?.mediaSession?.doesNotExist?.depth === undefined) {
_ddg_j = Object.bind(null);
} else {
_ddg_j = parentScope.navigator.mediaSession.doesNotExist.depth;
}
let _ddg_l
if (parentScope?.navigator?.mediaSession?.doesNotExist?.depth?.a === undefined) {
_ddg_l = Object.bind(null);
} else {
_ddg_l = parentScope.navigator.mediaSession.doesNotExist.depth.a;
}
let _ddg_h = parentScope?.navigator?.mediaSession?.doesNotExist ? parentScope.navigator.mediaSession.doesNotExist : Object.bind(null);
let _ddg_j = parentScope?.navigator?.mediaSession?.doesNotExist?.depth ? parentScope.navigator.mediaSession.doesNotExist.depth : Object.bind(null);
let _ddg_l = parentScope?.navigator?.mediaSession?.doesNotExist?.depth?.a ? parentScope.navigator.mediaSession.doesNotExist.depth.a : Object.bind(null);
let _ddg_m = "boop";
let _ddg_k = constructProxy(_ddg_l, {
lot: _ddg_m
Expand All @@ -72,12 +47,7 @@
mediaSession: _ddg_d
});
let navigator = _ddg_a;
let _ddg_o
if (parentScope?.document === undefined) {
_ddg_o = Object.bind(null);
} else {
_ddg_o = parentScope.document;
}
let _ddg_o = parentScope?.document ? parentScope.document : Object.bind(null);
let _ddg_p = "testingThisOut";
let _ddg_n = constructProxy(_ddg_o, {
cookie: _ddg_p
Expand Down