Fix firefox build #393
Merged
Fix firefox build #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzar
reviewed
Apr 6, 2023
jonathanKingston
force-pushed
the
jkt/fixFirefoxBuild
branch
from
2ccda94 to
c61ce47
Compare
jonathanKingston
force-pushed
the
jkt/fixFirefoxBuild
branch
from
c61ce47 to
f352744
Compare
shakyShane
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes up an issue of the missing arg into the build file, we should do all the arg processing in inject and pass through any processing into build.js
I've added some basic sanity checking of the files to the unit tests due to the lack of Firefox integration testing here or on the Extension side. With the Playwright migration of both repos we can address that properly.
Additionally this fixes up the broken platform name argument which has been missing for quite some time. (I don't think we actually need this in rollup given changes to iife)