Workaround declarativeNetRequest element collapsing bug #452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzar
force-pushed
the
fix-ctl-youtube-placeholders-p13
branch
2 times, most recently
from
8029a6b to
7dedcad
Compare
kzar
force-pushed
the
fix-ctl-youtube-placeholders-p13
branch
6 times, most recently
from
dff7bb8 to
97c7e57
Compare
jonathanKingston
approved these changes
Apr 25, 2023
There's a bug[1] with the declarativeNetRequest API that means that after blocked iframes are collapsed (hidden) they sometimes can't be uncollapsed (shown again) after they load successfully. That causes Click to Load to get messed up for Chrome MV3 builds of the extension, as the content is sometimes not shown to the user again after it has been unblocked. The bug is triggered when the collapsed iframe is removed from the DOM. As a workaround, let's load a benign data URI in blocked iframes before removing them from the DOM. That way they are uncollapsed, and so if they are added back to the page they will be visible to the user. 1 - https://crbug.com/1428971
kzar
force-pushed
the
fix-ctl-youtube-placeholders-p13
branch
from
97c7e57 to
63165ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bug[1] with the declarativeNetRequest API that means that
after blocked iframes are collapsed (hidden) they sometimes can't be
uncollapsed (shown again) after they load successfully. That causes
Click to Load to get messed up for Chrome MV3 builds of the extension,
as the content is sometimes not shown to the user again after it has
been unblocked. The bug is triggered when the collapsed iframe is
removed from the DOM.
As a workaround, let's load a benign data URI in blocked iframes
before removing them from the DOM. That way they are uncollapsed, and
so if they are added back to the page they will be visible to the
user.
1 - https://crbug.com/1428971