Use Reflect for script.src #453
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use reflect for script.src as some scripts bind this to call getAttribute causing a stack overflow.
Follow the steps in: duckduckgo/duckduckgo-privacy-extension#1913
cookielaw is exempted from stack tracing and pandadoc are exceptions; when they're enabled you'll see the stack overflow mentioned in the issue.
When you place a debugger within the class you see cookielaw has overriden us:
We're doing the reverse wishing to call
this[name]
which in turn callsgetAttribute
creating the infinite loop.