Dispatch Click to Load ready event again when necessary

[kzar]

The "ddg-ctp-ready" event is dispatched by the Click to Load
content-scope-script, to let the surrogate scripts know when the
feature is ready. Very occasionally that event is dispatched too
early, and so the surrogate script misses it. Workaround that by
dispatching the event again, if we see that a surrogate script
finished loading after page load has finished.

[ladamski]

Would this mean that ddg-ctp-ready sometimes fires twice, and that would result in multiple firings of onClickToPlayReady() in the surrogate?

If this second path is more reliable would it make sense to only use that? Or put a guard in onClickToPlayReady() to handle redundant calls?

[kzar]

Would this mean that ddg-ctp-ready sometimes fires twice, and that would result in multiple firings of onClickToPlayReady() in the surrogate?

Our event listener for ddg-ctp-ready uses the once: true option for that reason, to avoid it catching the event twice.

If this second path is more reliable would it make sense to only use that?

Yea, it might make sense to do that in the future. Thing is it would add quite a bit of complexity, keeping track of when the various surrogate scripts are ready and dispatching the relevant events only after that. I'd like to avoid it if we can, so far I've only ever see the ddg-ctp-ready event fire too early very occasionally on one website.

Edit: I'll add the surrogate-load event to the Facebook surrogate script too. That way, if we do decide to do this in the future we'll be ready.