macos duckplayer #459
Merged
macos duckplayer #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
shakyShane
force-pushed
the
shane/macos-duckplayer
branch
from
b0ad2bb to
d00eebd
Compare
jonathanKingston
requested changes
Apr 23, 2023
|
Sorry should have marked as draft, not quite ready for review - although the points raised are still valid, thanks :) |
shakyShane
force-pushed
the
shane/macos-duckplayer
branch
3 times, most recently
from
bab287d to
a2933e8
Compare
shakyShane
force-pushed
the
shane/macos-duckplayer
branch
3 times, most recently
from
14c4132 to
0fdd364
Compare
shakyShane
force-pushed
the
shane/macos-duckplayer
branch
2 times, most recently
from
5e651c4 to
03e0623
Compare
shakyShane
force-pushed
the
shane/macos-duckplayer
branch
5 times, most recently
from
c71facd to
02c4f37
Compare
shakyShane
force-pushed
the
shane/macos-duckplayer
branch
2 times, most recently
from
b3c4fdb to
c642191
Compare
shakyShane
force-pushed
the
shane/macos-duckplayer
branch
from
c642191 to
1acfdf2
Compare
|
@jonathanKingston - should be everything addressed now - I'll create a follow-up task in asana to review messaging construction once both mine + @franfaccin 's PRs have landed |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jonathanKingston time to get this reviewed/merged
apple-isolated(Duck Player Overlays being the only feature in it)