Skip to content

Add support for set and get attribute with a NS #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2023
Merged

Add support for set and get attribute with a NS #471

merged 1 commit into from
Apr 26, 2023

Conversation

jonathanKingston
Copy link
Contributor

Fixes #462

Captures calls with null and passes them through the trapped function.

@jonathanKingston jonathanKingston requested a review from dharb April 25, 2023 17:18
@jonathanKingston jonathanKingston mentioned this pull request Apr 25, 2023
Closed
@jonathanKingston jonathanKingston force-pushed the jkt/runtimeChecksSupportNS branch from 73a6864 to e5f0784 Compare April 25, 2023 17:25
dharb
dharb approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@dharb dharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jonathanKingston jonathanKingston merged commit ec67e16 into main Apr 26, 2023
@jonathanKingston jonathanKingston deleted the jkt/runtimeChecksSupportNS branch April 26, 2023 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dharb dharb dharb approved these changes

@shakyShane shakyShane Awaiting requested review from shakyShane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Script sources set using setAttributeNS(null, 'src', <url>) are ignored
2 participants
@jonathanKingston @dharb