Click to load: mobile block placeholder #525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franfaccin
force-pushed
the
ffaccin/ctl-mobile-block-placeholder
branch
from
ca9f4d9 to
a061a7a
Compare
src/features/click-to-load/components/ctl-placeholder-blocked.js
Outdated
Show resolved
Hide resolved
src/features/click-to-load/components/ctl-placeholder-blocked.js
Outdated
Show resolved
Hide resolved
src/features/click-to-load/components/ctl-placeholder-blocked.js
Outdated
Show resolved
Hide resolved
src/features/click-to-load/components/ctl-placeholder-blocked.js
Outdated
Show resolved
Hide resolved
kzar
reviewed
May 19, 2023
src/features/click-to-load/components/ctl-placeholder-blocked.js
Outdated
Show resolved
Hide resolved
kzar
reviewed
May 19, 2023
…e arrow functions and keep reference on Firefox
This container is set to copy the styles from the root element outside the shadow root. - Add Web Component lifecycle functions to update the styles from the Placeholder Blocked template when connected to the DOM and when the root elements gets its styles updated. - Use CSS classes to set the size and show/hide content instead of media queries. That because the size of the placeholder isn't related to the size of the screen. - Minor style adjustments.
- Add comment explaining new custom element - Rename DDGCtlPlaceholderBlocked -> DDGCtlPlaceholderBlockedElement - General fixes to CSS - reset styles from host element, clean up styles, etc
franfaccin
force-pushed
the
ffaccin/ctl-mobile-block-placeholder
branch
from
5ec413f to
eda47b9
Compare
- Introduce size-xs to show only the unblock button when there isn't enough height to show our placeholder copy -> pending review - Update CSS selectors to directly target size-md and size-lg when necessary. - Update the placeholder size after style updates from the parent element, because we change the root element height based on the parent size after injecting it on the page, and that might change our placeholder to a different size.
franfaccin
requested review from
ladamski,
jonathanKingston and
shakyShane
as code owners
shakyShane
requested changes
May 24, 2023
There was a problem hiding this comment.
@franfaccin great stuff!
I tried to reflect everything we spoke about in our call - let me know if I missed anything or if you have any questions :)
src/features/click-to-load/components/ctl-placeholder-blocked.js
Outdated
Show resolved
Hide resolved
src/features/click-to-load/components/ctl-placeholder-blocked.js
Outdated
Show resolved
Hide resolved
src/features/click-to-load/components/ctl-placeholder-blocked.js
Outdated
Show resolved
Hide resolved
src/features/click-to-load/components/ctl-placeholder-blocked.js
Outdated
Show resolved
Hide resolved
src/features/click-to-load/components/ctl-placeholder-blocked.js
Outdated
Show resolved
Hide resolved
…Introduce toggle size param and decouple it from platform logic
…a query to automatically update values to dark theme
…nstructor and split localized copy in different params
|
This is ready for review again :) |
shakyShane
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.