Skip to content

fix: remove the conditional that prevented some permissions being overridden on windows #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 22, 2023

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented May 22, 2023

re: https://app.asana.com/0/1201048563534612/1204619269374876/f

Added

  • ✅ tests for disabling windows permissions
  • ✅ tests written in a format that can be deployed to privacy-test-pages

@shakyShane
Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@shakyShane shakyShane force-pushed the shane/fix-windows-perms branch from 8502cfd to e11fe56 Compare May 22, 2023 12:30
@jonathanKingston jonathanKingston merged commit 561cb93 into main May 22, 2023
@jonathanKingston jonathanKingston deleted the shane/fix-windows-perms branch May 22, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants