Enable unused var lint check as an error #545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanKingston
force-pushed
the
jkt/enableUnusedVars
branch
from
98b0f5d to
03475b8
Compare
jonathanKingston
force-pushed
the
jkt/enableUnusedVars
branch
from
03475b8 to
af5a64f
Compare
muodov
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes linting errors that are drowning every PR. I've not really checked but
@typescript-eslint/no-unused-varsI think replaces the defaultno-unused-varswhich is why we've had the slow creep of this code.I've accepted some of them as there's some follow up PR with my code but the rest I've fixed.