Skip to content

Overriden taint methods #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 2, 2023
Merged

Overriden taint methods #549

merged 9 commits into from
Jun 2, 2023

Conversation

jonathanKingston
Copy link
Contributor

Copy link
Contributor

@shakyShane shakyShane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of comments and 1 question around localStorage/sessionStorage

@jonathanKingston jonathanKingston force-pushed the jkt/overridenTaintMethods branch 4 times, most recently from e8c3c8a to acbf936 Compare June 1, 2023 17:05
@jonathanKingston jonathanKingston force-pushed the jkt/overridenTaintMethods branch from acbf936 to 9ebc0d2 Compare June 1, 2023 17:06
Copy link
Contributor

@shakyShane shakyShane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple more about storage :)

@jonathanKingston jonathanKingston force-pushed the jkt/overridenTaintMethods branch from d64f9f1 to 1c27503 Compare June 2, 2023 08:18
@jonathanKingston jonathanKingston force-pushed the jkt/overridenTaintMethods branch from 1c27503 to 475abc7 Compare June 2, 2023 08:19
@jonathanKingston jonathanKingston force-pushed the jkt/overridenTaintMethods branch from 6804ace to 53dfda6 Compare June 2, 2023 08:35
@shakyShane
Copy link
Contributor

Approving on the basis that we can disable easily - it's something that needs verifying in the wild now :)

@jonathanKingston jonathanKingston merged commit 2ef0a98 into main Jun 2, 2023
@jonathanKingston jonathanKingston deleted the jkt/overridenTaintMethods branch June 2, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants