Skip to content

Fix issue to get accurate iframe video src #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 15, 2023
Merged

Fix issue to get accurate iframe video src #573

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
edef703
Fix issue to get accurate iframe video src
franfaccin Jun 14, 2023
4c34274
Merge branch 'main' into fix-yt-src-ref
franfaccin Jun 14, 2023
df2f160
Merge branch 'main' into fix-yt-src-ref
franfaccin Jun 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/features/click-to-load.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,7 +523,7 @@ function replaceTrackingElement (widget, trackingElement, placeholderElement) {
// from the DOM after they are collapsed. As a workaround, have the iframe
// load a benign data URI, so that it's uncollapsed, before removing it from
// the DOM. See https://crbug.com/1428971
const originalSrc = elementToReplace.src
const originalSrc = elementToReplace.src || elementToReplace.getAttribute('data-src')
elementToReplace.src =
'data:text/plain;charset=utf-8;base64,' + btoa('https://crbug.com/1428971')

Expand Down