Skip to content

Add overloading of property descriptors #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 22, 2023

Conversation

jonathanKingston
Copy link
Contributor

https://app.asana.com/0/569473074191537/1204844629773408/f

  • Disable the exception we currently have for xfinity
  • Also enable all stack trace checking with "matchAllStackDomains": "enabled",
  • Also enable this with "overloadGetOwnPropertyDescriptor": "enabled"
  • Go to xfinity,

Without this patch you see exceptions about illegal invocation, with they should be gone.

@jonathanKingston jonathanKingston force-pushed the jkt/overloadGetOwnPropertyDescriptors branch 4 times, most recently from 284ac91 to faec383 Compare June 22, 2023 10:39
@jonathanKingston jonathanKingston force-pushed the jkt/overloadGetOwnPropertyDescriptors branch from faec383 to d553e84 Compare June 22, 2023 11:05
shakyShane
shakyShane previously approved these changes Jun 22, 2023
@jonathanKingston jonathanKingston marked this pull request as draft June 22, 2023 13:04
@jonathanKingston jonathanKingston force-pushed the jkt/overloadGetOwnPropertyDescriptors branch from e45145d to 8a1857a Compare June 22, 2023 13:23
@jonathanKingston jonathanKingston marked this pull request as ready for review June 22, 2023 13:27
@jonathanKingston jonathanKingston merged commit 11d6005 into main Jun 22, 2023
@jonathanKingston jonathanKingston deleted the jkt/overloadGetOwnPropertyDescriptors branch June 22, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants