fix(duckplayer): prevent stale references to DOM nodes #595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
shakyShane
force-pushed
the
shane/duckplayer/remove-refs
branch
2 times, most recently
from
009f72a to
bb7d353
Compare
shakyShane
force-pushed
the
shane/duckplayer/remove-refs
branch
from
bb7d353 to
07d511b
Compare
|
Merged since @SabrinaTardio and I have tested the native integrations extensively |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.asana.com/0/1203249713006009/1204905284325687/f
In some instances, we were holding onto DOM nodes for too long. We were checking
isConnectedto ensure we didn't call methods on DOM nodes that were no longer in the page - which was great for preventing exceptions, but it meant in lots of cases we were not able to pause the video or present our overlay consistently