fix(duckplayer): fix overlays on shorts #603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
shakyShane
commented
Jun 28, 2023
| // this can occur with 'shorts' | ||
| if (video.href !== before) { | ||
| if (!VideoThumbnail.isSingleVideoURL(video.href)) { | ||
| return console.log('bailing because the video has changed') |
There was a problem hiding this comment.
This is the fix - we double-check the video.href to guard against DOM mutations
shakyShane
force-pushed
the
shane/duckplayer/shorts
branch
from
673d743 to
9b89715
Compare
shakyShane
force-pushed
the
shane/duckplayer/shorts
branch
from
9b89715 to
d1e7282
Compare
shakyShane
changed the title
shakyShane
force-pushed
the
shane/duckplayer/shorts
branch
from
b7853a4 to
d1e7282
Compare
|
This was tested extensively on macOS by myself + @ayoy, moving forward with a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.asana.com/0/1203249713006009/1204911763532130/f