fix(web-compat): run web-compat first in webkit environments #606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
|
Can you remove the assets changes? |
shakyShane
force-pushed
the
07-03-fix_web-compat_run_web-compat_first_in_webkit_environments
branch
from
186efab to
528ad48
Compare
|
Tested and verified within duckduckgo/macos-browser#1327 |
shakyShane
deleted the
07-03-fix_web-compat_run_web-compat_first_in_webkit_environments
branch
jonathanKingston
pushed a commit
that referenced
this pull request
Jul 12, 2023
* fix(web-compat): ensure webCompat runs before fingerprinting * remove `fit` --------- Co-authored-by: Shane Osbourne <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix here is just to ensure
webCompatruns earlier on the page - I will fast-follow with an integration test once I figure out why this occures.The PR contains the artefacts to make it easier to review - they'll be removed before merge
https://github.com/duckduckgo/content-scope-scripts/pull/606/files#diff-5cdfca025137b215b9294f8a2f6d0893270002cbf3f7b8efb771da44971382c7