Skip to content

WIP - Add a npm run serve script to serve integration pages #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 48 additions & 24 deletions integration-test/helpers/harness.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import * as fs from 'fs'
import * as os from 'os'
import * as path from 'path'
import * as http from 'http'
import puppeteer from 'puppeteer'
import { spawnSync } from 'child_process'
import { fork, spawnSync } from 'child_process'
import { join } from 'path'

jasmine.DEFAULT_TIMEOUT_INTERVAL = 20000
if (process.env.KEEP_OPEN) {
Expand Down Expand Up @@ -35,7 +35,7 @@ export async function setup (ops = {}) {
}

const browser = await puppeteer.launch(puppeteerOps)
const servers = []
const cleanups = []

async function teardown () {
if (process.env.KEEP_OPEN) {
Expand All @@ -51,7 +51,7 @@ export async function setup (ops = {}) {
}

async function teardownInternal () {
await Promise.all(servers.map(server => server.close()))
await Promise.all(cleanups.map((fn) => fn()))
await browser.close()

// necessary so e.g. local storage
Expand All @@ -61,27 +61,12 @@ export async function setup (ops = {}) {

/**
* @param {number|string} [port]
* @returns {http.Server}
* @returns {{address: string}}
*/
function setupServer (port) {
const server = http.createServer(function (req, res) {
const url = new URL(req.url, `http://${req.headers.host}`)
const importUrl = new URL(import.meta.url)
const dirname = importUrl.pathname.replace(/\/[^/]*$/, '')
const pathname = path.join(dirname, '../pages', url.pathname)

fs.readFile(pathname, (err, data) => {
if (err) {
res.writeHead(404)
res.end(JSON.stringify(err))
return
}
res.writeHead(200)
res.end(data)
})
}).listen(port)
servers.push(server)
return server
async function setupServer (port) {
const { address, close } = await forkServer(port)
cleanups.push(close)
return { address }
}

/**
Expand Down Expand Up @@ -122,3 +107,42 @@ export async function setup (ops = {}) {

return { browser, teardown, setupServer, gotoAndWait }
}

/**
* @returns {Promise<{address: any, close: ()=>void}>}
*/
function forkServer (port) {
const cwd = new URL('../../', import.meta.url)
const script = join(cwd.pathname, 'scripts', 'serve-pages.js')
return new Promise((resolve) => {
const server = fork(script, {
stdio: 'inherit',
cwd,
env: {
PORT: port
}
})
function close () {
return new Promise((resolve, reject) => {
server.on('close', (code) => {
if (code === null || code === 0) {
resolve(code)
} else {
reject(new Error(`server closed with none-zero exit code ${code}`))
}
})
server.kill()
})
}
server.on('message', (msg) => {
if (msg.kind !== 'server-listening') {
console.log('unknown message', msg)
return
}
resolve({
address: msg.address,
close
})
})
})
}
1 change: 0 additions & 1 deletion integration-test/pages/build

This file was deleted.

13 changes: 6 additions & 7 deletions integration-test/test-fingerprint.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ describe('Fingerprint Defense Tests', () => {
beforeAll(async () => {
({ browser, teardown, setupServer } = await setup())

setupServer('8080')
setupServer('8383')
await setupServer('8080')
await setupServer('8383')
})
afterAll(async () => {
await teardown()
Expand Down Expand Up @@ -76,8 +76,8 @@ describe('First Party Fingerprint Randomization', () => {
beforeAll(async () => {
({ browser, setupServer, teardown } = await setup())

setupServer('8080')
setupServer('8383')
await setupServer('8080')
await setupServer('8383')
})
afterAll(async () => {
await teardown()
Expand Down Expand Up @@ -144,9 +144,8 @@ describe('Verify injected script is not visible to the page', () => {
let setupServer
beforeAll(async () => {
({ browser, setupServer, teardown } = await setup())

setupServer('8080')
setupServer('8383')
await setupServer('8080')
await setupServer('8383')
})
afterAll(async () => {
await teardown()
Expand Down
6 changes: 2 additions & 4 deletions integration-test/test-navigator-interface.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,15 @@ describe('Ensure navigator interface is injected', () => {
let gotoAndWait
beforeAll(async () => {
({ browser, setupServer, teardown, gotoAndWait } = await setup({ withExtension: true }))
server = setupServer()
server = await setupServer()
})
afterAll(async () => {
await server?.close()
await teardown()
})

it('should expose navigator.navigator.isDuckDuckGo(): Promise<boolean> and platform === "extension"', async () => {
const port = server.address().port
const page = await browser.newPage()
await gotoAndWait(page, `http://localhost:${port}/blank.html`, { platform: { name: 'extension' } })
await gotoAndWait(page, `${server.address}/blank.html`, { platform: { name: 'extension' } })
const isDuckDuckGoResult = await page.evaluate(
() => {
const fn = navigator.duckduckgo?.isDuckDuckGo
Expand Down
Loading