Skip to content

Export globals correctly for Firefox #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2022
Merged

Export globals correctly for Firefox #9

merged 1 commit into from
Jan 12, 2022

Conversation

jonathanKingston
Copy link
Contributor

@jonathanKingston jonathanKingston commented Jan 12, 2022 •
edited
Loading

This fixes the built issue in Firefox, I thought I was going insane. The move itself to this repo wasn't the cause.

Fixes:

  • Moving to globalThis doesn't have the correct wrappedJSObject xray behaviour for firefox.
  • Fixed tests to use globalThis
  • for value passed to define property we now cloneInto which exports all the properties correctly...
  • However async functions don't export as they have a then() that isn't. We could write up a scoped task to explore if this is fixable.

Task: https://app.asana.com/0/312629933896096/1201651398928031/f

@jonathanKingston jonathanKingston merged commit 4426f9d into main Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shakyShane shakyShane shakyShane approved these changes

@sammacbeth sammacbeth Awaiting requested review from sammacbeth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathanKingston @shakyShane