Fix comment and add another comment #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment seems to got wrong over time: The config made sense first: df6286b#diff-e45e45baeda1c1e73482975a664062aa56f20c03dd9d64a827aba57775bed0d3 Then the config became obsolete: 4e25808 Then the config became a (I think wrong) comment: 0167334#diff-e45e45baeda1c1e73482975a664062aa56f20c03dd9d64a827aba57775bed0d3 I don't use Mac so I don't know but maybe the whole comment could be removed completely since the `cached` option was introduced.
|
Good catch, thanks. We need to backport this in api-platform/api-platform. |
LucasHospice
pushed a commit
to LucasHospice/symfony-docker
that referenced
this pull request
Feb 21, 2024
This comment seems to got wrong over time: The config made sense first: dunglas@df6286b#diff-e45e45baeda1c1e73482975a664062aa56f20c03dd9d64a827aba57775bed0d3 Then the config became obsolete: dunglas@4e25808 Then the config became a (I think wrong) comment: dunglas@0167334#diff-e45e45baeda1c1e73482975a664062aa56f20c03dd9d64a827aba57775bed0d3 I don't use Mac so I don't know but maybe the whole comment could be removed completely since the `cached` option was introduced.
VitaliyMinenko
pushed a commit
to VitaliyMinenko/notofication-service
that referenced
this pull request
Sep 16, 2024
This comment seems to got wrong over time: The config made sense first: dunglas@df6286b#diff-e45e45baeda1c1e73482975a664062aa56f20c03dd9d64a827aba57775bed0d3 Then the config became obsolete: dunglas@4e25808 Then the config became a (I think wrong) comment: dunglas@0167334#diff-e45e45baeda1c1e73482975a664062aa56f20c03dd9d64a827aba57775bed0d3 I don't use Mac so I don't know but maybe the whole comment could be removed completely since the `cached` option was introduced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment seems to got wrong over time:
The config made sense first: df6286b#diff-e45e45baeda1c1e73482975a664062aa56f20c03dd9d64a827aba57775bed0d3
Then the config became obsolete: 4e25808
Then the config became a (I think wrong) comment: 0167334#diff-e45e45baeda1c1e73482975a664062aa56f20c03dd9d64a827aba57775bed0d3
I don't use Mac so I don't know but maybe the whole comment could be removed completely since the
cachedoption was introduced.