Skip to content

Basic readme telling how to select symfony version #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 23, 2018
Merged

Basic readme telling how to select symfony version #23

merged 3 commits into from
Aug 23, 2018

Conversation

mateuszsip
Copy link
Contributor

No description provided.

@dunglas
Copy link
Owner

dunglas commented Jun 24, 2018

Can you remove it from the generated ZIP archive please? You can do like this: https://github.com/api-platform/api-platform/blob/master/.gitattributes#L21

dunglas
dunglas reviewed Jun 24, 2018
View reviewed changes
README.md Outdated

Like:

`SYMFONY_VERSION=3.4 docker-compose up -d`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a note about the stability flag too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. And I noticed we should merge a little fix first (#25)

@mateuszsip
Copy link
Contributor Author

#25 was merged, so if it's ok we can merge this one

@dunglas dunglas merged commit 29cc31c into dunglas:master Aug 23, 2018
@dunglas
Copy link
Owner

dunglas commented Aug 23, 2018

Thanks @kejwmen! I made some minor modifications.

LucasHospice pushed a commit to LucasHospice/symfony-docker that referenced this pull request Feb 21, 2024
@mateuszsip @LucasHospice
Basic readme telling how to select symfony version (dunglas#23)
1622662 
* Basic readme telling how to select symfony version

* Describe installing symfony with custom stability

* Update README.md
VitaliyMinenko pushed a commit to VitaliyMinenko/notofication-service that referenced this pull request Sep 16, 2024
@mateuszsip @dunglas
Basic readme telling how to select symfony version (dunglas#23)
b801a1f 
* Basic readme telling how to select symfony version

* Describe installing symfony with custom stability

* Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas dunglas left review comments

@maks-rafalko maks-rafalko maks-rafalko approved these changes

@maxhelias maxhelias maxhelias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mateuszsip @dunglas @maks-rafalko @maxhelias