Skip to content

Gather all Dockerfile in one #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2018

Conversation

maxhelias
Copy link
Collaborator

Use a single Dockerfile

@ajardin
Copy link
Contributor

ajardin commented Jun 26, 2018

That's only my personal point of view, but I'm generally against this kind of writing since the final result is less readable. 😕

@dunglas Is there any specific benefit (workflow, performance, etc.) for merging everything into a single file? I saw you did the same change for API Platform a couple of days ago.

args:
SYMFONY_VERSION: ${SYMFONY_VERSION}
STABILITY: ${STABILITY}
volumes:
# Comment out the next line in production
- ./:/srv/app:rw
- ./:/srv/app:rw,delegated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be cached

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, I rebase the branch

@maxhelias maxhelias force-pushed the all-in-one-dockerfile branch from 1ad6efb to 6d77b4b Compare July 1, 2018 16:25
@jorge07
Copy link
Contributor

jorge07 commented Jul 2, 2018

Docker is about process isolation. Using docker as a Vagrant box is a mistake.

@dunglas
Copy link
Owner

dunglas commented Jul 2, 2018

@jorge07 process are still isolated. It's one file that creates several containers.
@ajardin It's more in the spirit of Flex (less files, minimal setup), only the minimal things required to get started. Also it allows to be in sync with api-platform/api-platform: api-platform/api-platform#666

@jorge07
Copy link
Contributor

jorge07 commented Jul 2, 2018

@dunglas I didn't saw you're using target so yes, my fault.
Still having my concerns about having a single Dockerfile for all the stack. Where is single responsibility then?
Any blog post or related explaining pros-cons?

@johnutzm
Copy link

johnutzm commented Aug 6, 2018

Currently Docker does not support skipping stages (docker/cli#1134). If you want to build the last target in the Dockerfile everything will be built.

@dunglas dunglas merged commit 3ee156c into dunglas:master Aug 23, 2018
@dunglas
Copy link
Owner

dunglas commented Aug 23, 2018

Thanks @maxhelias!

@maxhelias maxhelias deleted the all-in-one-dockerfile branch October 7, 2019 11:35
VitaliyMinenko pushed a commit to VitaliyMinenko/notofication-service that referenced this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants