-
-
Notifications
You must be signed in to change notification settings - Fork 847
Gather all Dockerfile in one #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
That's only my personal point of view, but I'm generally against this kind of writing since the final result is less readable. 😕 @dunglas Is there any specific benefit (workflow, performance, etc.) for merging everything into a single file? I saw you did the same change for API Platform a couple of days ago. |
docker-compose.yaml
Outdated
args: | ||
SYMFONY_VERSION: ${SYMFONY_VERSION} | ||
STABILITY: ${STABILITY} | ||
volumes: | ||
# Comment out the next line in production | ||
- ./:/srv/app:rw | ||
- ./:/srv/app:rw,delegated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be cached
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, I rebase the branch
1ad6efb
to
6d77b4b
Compare
Docker is about process isolation. Using docker as a Vagrant box is a mistake. |
@jorge07 process are still isolated. It's one file that creates several containers. |
@dunglas I didn't saw you're using |
Currently Docker does not support skipping stages (docker/cli#1134). If you want to build the last target in the Dockerfile everything will be built. |
Thanks @maxhelias! |
Gather all Dockerfile in one
Use a single Dockerfile