Skip to content

Windows performance hint #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2022
Merged

Windows performance hint #270

merged 2 commits into from
Jul 31, 2022

Conversation

robinbrisa
Copy link
Contributor

Added commented lines in docker-compose.override.yml about improving performance on Windows by using Docker volumes for the vendor and var directories.

Information found in issue #242.

Added lines about improving performance on Windows by using Docker volumes for vendor and var
Added mention of Windows for the performance increase and added the vendor directory to the bind-mount exclusion
@robinbrisa
Copy link
Contributor Author

robinbrisa commented Jul 31, 2022

Salut Kévin, you're right, using the same syntax works indeed.
I just made some tests and the vendor dir needs to be added as it's the one which makes the most difference performance-wise. Not sure if it's the same on Mac though.
I pushed a new version to reflect this, removing the volumes and adding the vendor directory to the bind-mount exclusion.

@robinbrisa robinbrisa requested a review from dunglas July 31, 2022 11:56
@dunglas dunglas merged commit e29fc44 into dunglas:main Jul 31, 2022
@dunglas
Copy link
Owner

dunglas commented Jul 31, 2022

Thanks! And yes excluding the vendors improves performance on Mac too, but the drawback is that it's harder to hack a dependency (when working with a private Packagist instance hosting company packages or when hacking an open source library).

Anthodev added a commit to Anthodev/symfony-docker that referenced this pull request Sep 22, 2022
* Typo fix

* Remove iconv workaround

* Replace unsupported wip tld by localhost (dunglas#254)

* ICU 71.1 support

* feat: remove deprecated flags

* feat: improve PHP config (dunglas#266)

* feat: improve PHP config

Tweak PHP config according to Blackfire's recommendation.

* Update docker/php/conf.d/symfony.prod.ini

Co-authored-by: Jacob Dreesen <[email protected]>

* fix

* fix

Co-authored-by: Jacob Dreesen <[email protected]>

* feat: Promote Compose v2

* Windows performance hint (dunglas#270)

* docs: trust certificate on Windows (dunglas#272)

Added information about how to add the caddy cert to the trusted certificates on Windows as this info was only provided for Linux & Mac.

* feat: add native Xdebug support (dunglas#271)

* feat: add native Xdebug support

* cleanup

* fix review

* fix review

* Improve docs

* some more improvements

* remove useless env var

* Update README.md

* Update README.md

* refactor: improve image, uniformize with API Platform  (dunglas#275)

* refactor: improve image, uniformize with API Platform

* feat: remove the SKELETON arg

* chore: minor improvements and sync with API Platform (dunglas#277)

* chore: compatibility with the new ORM recipe (dunglas#278)

* chore: add a default value for XDEBUG_MODE

* fix: stop use obsolete experimental_http3 option

* Feat/supercharged symfony docker (#1)

* 📦 NEW: Makefile + modified ci / dockerfile /README

* 🐛 FIX: added a way to restore permission for the files

* 🐛 FIX: Removed --no-deps option for php command in Docker through Makefile

* 👌 IMPROVE: Added user permissions to manage file permissions

* 🐛 FIX: remove an instruction in Dockerfile

* 🐛 FIX: fixing permissions on small part of the Dockerfile

Co-authored-by: Dezső BICZÓ <[email protected]>
Co-authored-by: Douglas Silva <[email protected]>
Co-authored-by: Steven DUBOIS <[email protected]>
Co-authored-by: Jérôme Zecca <[email protected]>
Co-authored-by: Stéphane P <[email protected]>
Co-authored-by: Kévin Dunglas <[email protected]>
Co-authored-by: Jacob Dreesen <[email protected]>
Co-authored-by: Maxime Hélias <[email protected]>
Co-authored-by: Robin Brisa <[email protected]>
Co-authored-by: Borislav Kosun <[email protected]>
LucasHospice pushed a commit to LucasHospice/symfony-docker that referenced this pull request Feb 21, 2024
VitaliyMinenko pushed a commit to VitaliyMinenko/notofication-service that referenced this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants