Skip to content

Fix markdown fail issue#42 #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 5, 2018
Merged

Fix markdown fail issue#42 #43

merged 6 commits into from
Jul 5, 2018

Conversation

nelsonic
Copy link
Member

see: #42
fixed:
image

@nelsonic nelsonic mentioned this pull request Jun 19, 2018
package.json Outdated
"start": "live-server --port=8000 --open=./examples",
"test": "istanbul cover test/test.js",
"check-coverage": "istanbul cover test/test.js && istanbul check-coverage --statements 100 --functions 100 --lines 100 --branches 100",
"postinstall": "npm test && npm start",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to delete this line as it causes the build to "hang" (unsurprisingly, in retrospect! doh!)
https://travis-ci.org/dwyl/learn-elm-architecture-in-javascript/builds/394115145#L551

@nelsonic nelsonic requested a review from iteles June 28, 2018 11:36
Copy link
Collaborator

@dwylbot dwylbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
image

@dwylbot dwylbot merged commit 814467e into master Jul 5, 2018
@dwylbot dwylbot deleted the fix-markdown-fail-issue#42 branch July 5, 2018 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants