Skip to content

Update the included Adafruit_TinyUSB_Arduino library to 2.4.1 #2002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

zjwhitehead
Copy link

This updates the library to the latest 2.x release as of this PR.

@earlephilhower
Copy link
Owner

Thanks, but it looks like there are some fatal warnings in the library examples and an actual failure in the Platform.IO TinyUSB example build with this version.

@zjwhitehead
Copy link
Author

You're right, thats strange. I didnt expect any breaking changes but it appears so

@maxgerhardt
Copy link
Contributor

maxgerhardt commented Feb 21, 2024

Arduino-Pico regular CI build shows that the -Werror flag is in the mix (explicitly set), this will hard-abort with the first warning, which the new Adafruit TinyUSB version has due to not initializing a member in a struct.

PlatformIO fails possibly because of what I've already discovered in this PR, regarding

While working on this I also noticed that at least for PlatformIO the include/tusb_config.h file seemed not actually used (you can place a #error in there and it will still compile), which is due to the include order in PlatformIO being that the original Adafruit TinyUSB library's tusb_config.h is first, and then the include/ for Arduino-Pico follows. Resolved by making use of the CFG_TUSB_CONFIG_FILE macro and pointing it to the uniquely named config file.

At the time the configs were probably equivalent, now the standard config in Adafruit has changed, so not maybe anymore.

@earlephilhower
Copy link
Owner

adafruit/Adafruit_TinyUSB_Arduino#386 takes care of the GCC warning/error. Is there something we can do here with P.IO for the header problem?

@earlephilhower
Copy link
Owner

Closing as Adafruit is up to 3.1 now.

schkovich pushed a commit to schkovich/arduino-pico that referenced this pull request May 24, 2025
schkovich pushed a commit to schkovich/arduino-pico that referenced this pull request May 24, 2025
- Re-synchronise the PICO_CMAKE_CONFIG: entries with the corresponding PICO_CONFIG: entries
 - Fix a silly typo I made in earlephilhower#2002
 - Enhance config-extraction scripts to catch similar typos in future
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants