This repository was archived by the owner on Feb 24, 2021. It is now read-only.
Initial Docker Compose files with for Redis default #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresrinivasan
force-pushed
the
issue-215-non-secure-edgex-redis-default
branch
from
fe621df to
a6f9365
Compare
AnthonyMBonafide
previously requested changes
Feb 7, 2020
There was a problem hiding this comment.
With the proposed changes in edgexfoundry/edgex-go#2335, I think we will need to overwrite the default configuration for the services when we want to use Mongo since they will use Redis by default. I may be wrong here and missing something.
andresrinivasan
force-pushed
the
issue-215-non-secure-edgex-redis-default
branch
3 times, most recently
from
31b12b0 to
dcad6b0
Compare
michaelestrin
suggested changes
Feb 7, 2020
andresrinivasan
force-pushed
the
issue-215-non-secure-edgex-redis-default
branch
2 times, most recently
from
d546005 to
1ab7381
Compare
Updated. |
Signed-off-by: Andre Srinivasan <[email protected]>
andresrinivasan
force-pushed
the
issue-215-non-secure-edgex-redis-default
branch
from
1ab7381 to
5581cb8
Compare
|
@michaelestrin @AnthonyMBonafide all good? |
michaelestrin
dismissed
AnthonyMBonafide’s stale review
Review comments addressed; Anthony unavailable to re-review.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #215
Tested via blackbox tests. See also blackbox-testing PR #385
Signed-off-by: Andre Srinivasan [email protected]